Change serialization syntax #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string as following In previous version: string_param1 string_value string_param2 string value In this version: string_param1 "string_value" string_param2 "string\nvalue" I don't change serialization format for other types.
Because we use `element.v1_config == false` always.
| opts[:type] | ||
| end | ||
|
|
||
| def dump_value(k, v, indent, nindent) |
There was a problem hiding this comment.
Is there any reason to assign out = "" at once and then do out << "..."?
It looks good enough just to return string value by if expression.
There was a problem hiding this comment.
Exactly.
I will fix this.
|
I've fixed and pushed. |
|
Merged! Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string as following
In previous version:
string_param1 string_value
string_param2 string
value
In this version:
string_param1 "string_value"
string_param2 "string\nvalue"
I don't change serialization format for other types.
See #522