Register plugin into registry #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove original plugin dictionaries and replace them with registry * move registries for parser/formatter to plugin.rb
| case | ||
| when obj.is_a?(Class) | ||
| obj.new | ||
| when obj.respond_to?(:call) |
There was a problem hiding this comment.
The number of arity check is needed?
There was a problem hiding this comment.
Correct. Better to have.
|
@repeatedly Can I merge after fixes of your points? |
|
Yes. @sonots Could you also check this? |
* custom plugin directly must be able to override built-in files
|
LGTM |
|
OK. I'll merge this after green (Travis is already ok. Waiting appveyor). |
|
An Appveyor task in a job is failing weird error and there's no way to rebuild it... I'll merge this :P |
tagomoris
added a commit
that referenced
this pull request
Mar 10, 2016
Register plugin into registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make straightforward dependencies from kinds of plugins to plugin.rb, and reduce duplicated implementation between plugin.rb and registry.rb.