Fix to do require for required files straightforward, per files
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently, all required files are loaded by `lib/fluent/load.rb` even for tests * This file creates the implicit order of files to be loaded * There's no explicit dependency definition, and there are many circular dependencies * This situation is totally broken * Without this change, we can't run tests by `bundle exec rake test TEST=test/file.rb` * Running whole tests consumes long time, and it's not acceptable This change is to make straightforward dependency from all files to others. We can load any file in fluentd source code, make clean dependencies, and also can run each files itself to test it.
|
Test on TravisCI is failed but this failure does not seem to be related to this PR. |
|
@tagomoris Can we merge this PR? |
repeatedly
added a commit
that referenced
this pull request
Mar 2, 2016
Fix to do `require` for required files straightforward, per files
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/fluent/load.rbeven for testsbundle exec rake test TEST=test/file.rbThis change is to make straightforward dependency from all files to others.
We can load any file in fluentd source code, make clean dependencies, and
also can run each files itself to test it.
For v0.12 branch,