Modify TimeSlicedOutput#emit mechanizm to fit BufferedOutput#emit way #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current TimeSlicedOutput#emit emits records to buffer one by one. It causes inconsistent state when queue has a problem. For example, some records are stored into buffers and raises BufferQueueLimitError. In this situation, logs are duplicated if input plugin retries. BufferedOutput and ObjectBufferedOutput uses another way. These outputs format all records into data chunk first. It is more safer than current TimeSlicedOutput way.
|
LGTM, except for failing tests :D |
|
If there is no concern, I will merge this today. |
repeatedly
added a commit
that referenced
this pull request
Jul 20, 2015
Modify TimeSlicedOutput#emit mechanizm to fit BufferedOutput#emit way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current TimeSlicedOutput#emit emits records to buffer one by one.
It causes inconsistent state when queue has a problem.
For example, some records are stored into buffers and
raises BufferQueueLimitError. In this situation,
logs are duplicated if input plugin retries.
BufferedOutput and ObjectBufferedOutput uses another way.
These outputs format all records into data chunk first.
New behaviour is more safer than current TimeSlicedOutput way.
@sonots @tagomoris Could you check this patch? It increases temporary memory usage but current behaviour should be fixed.