-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log unused section configuration as warn level #629
Conversation
@@ -30,9 +30,10 @@ def initialize(name, arg, attrs, elements, unused = nil) | |||
@unused = unused || attrs.keys | |||
@v1_config = false | |||
@corresponding_proxies = [] # some plugins use flat parameters, e.g. in_http doesn't provide <format> section for parser. | |||
@unused_in = false # if this element is not used in plugins, correspoing plugin name is set. otherwise nil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default value false
is against to comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other wise refers to "if this element is not used". I will add more line.
fc5d82c
to
5883756
Compare
Apply review. Please check again. @sonots Could you check this too? |
Here is logged example:
|
5883756
to
e2f8dc6
Compare
If no problem, I will merge it today. |
If you ok, please merge this. |
Log unused section configuration as warn level
Signed-off-by: abicky <[email protected]>
@tagomoris Could you check this?