-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new csv formatter #489
Conversation
Code looks good. |
assert_equal [], @formatter.fields | ||
end | ||
|
||
def test_config_params_with_customized_delimiters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use data
approach instead of each assert in one test?
fluentd/test/plugin/test_filter_grep.rb
Line 109 in 1c70884
data( |
I commented and others are looks OK. I think CSV/TSV is popular and Ruby has CSV library in standard library. |
1ea426a
to
fe2a1a0
Compare
I fixed tests, could you review it again? |
This pull request is adding new formatter named 'csv' to format log in csv(or tsv) style.
We can config like as follows:
We can output in also tsv style by setting 'delimiter':