out_file: don't create world writable directory in daemon mode #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to reproduce:
Create the following config file as file-fluentd.conf:
<source>
type forward
</source>
<match **>
type file
path /tmp/x/y/z/a
</match>
Start fluentd:
% ruby -I lib bin/fluentd -c file-fluentd.conf --daemon fluentd.pid
Check permission of /tmp/x:
% stat /tmp/x | grep Access
Access: (0777/drwxrwxrwx) Uid: ( 1000/ kou) Gid: ( 1000/ kou)
Access: 2014-11-21 17:15:59.898444064 +0900
Permission is "0777/drwxrwxrwx".
Because daemon mode changes umask to `0000`. (It's natural for daemon.)
repeatedly
added a commit
that referenced
this pull request
Nov 22, 2014
out_file: don't create world writable directory in daemon mode
|
Thanks! |
|
cherry-picked to v0.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Create the following config file as file-fluentd.conf:
Start fluentd:
Check permission of /tmp/x:
Permission is "0777/drwxrwxrwx".
Because daemon mode changes umask to
0000. (It's natural for daemon.)