-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer: backup broken file chunk #4025
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backup feature was implemented in fluent#1952, but it didn't support handling broken file chunks found in resuming buffer. This extends the backup feature to support it. Signed-off-by: Daijiro Fukuda <[email protected]>
I'm fixing |
Hmm, I thought this was OK since this doesn't change the config shape, but it seems this is not good. |
Signed-off-by: Daijiro Fukuda <[email protected]>
`disable_chunk_backup` option is still in `buffer` section, but it is moved into `Buffer` from `Output`. Signed-off-by: Daijiro Fukuda <[email protected]>
ashie
reviewed
Feb 13, 2023
ashie
reviewed
Feb 13, 2023
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
force-pushed
the
backup-broken-filechunk
branch
from
February 13, 2023 06:08
8621d15
to
6152b8f
Compare
cosmo0920
reviewed
Feb 13, 2023
Signed-off-by: Daijiro Fukuda <[email protected]>
ashie
reviewed
Feb 13, 2023
Signed-off-by: Daijiro Fukuda <[email protected]>
ashie
reviewed
Feb 15, 2023
Thanks for your review! |
daipom
added a commit
to daipom/fluentd-docs-gitbook
that referenced
this pull request
Mar 29, 2023
* fluent/fluentd#4025 * fluent/fluentd#4028 Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Partial fix for #3970
What this PR does / why we need it:
Backup feature was implemented in #1952, but it didn't support handling broken file chunks found in resuming buffer.
This extends the backup feature to support it.
When a file is corrupted due to power failure or other reasons, backing up the file allows us to guess which data was corrupted.
Example of a forwarder:
We can reproduce file corruption due to power failure as follows.
(Especially in Windows, a phenomenon in which the data being edited is turned to a sequence of zero is confirmed.)
Then, restart the fluentd, and it backups the chunk.
The logs of fluentd are as follows.
We can check the backup file as follows.
Docs Changes:
Release Note:
Same as the title.