in_tail: Fix rotation related resource leak. fix #1941 #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <[email protected]>
okkez
requested changes
Aug 16, 2018
lib/fluent/plugin/in_tail.rb
Outdated
| # If this has a problem with large number of files, use @_event_loop directly. | ||
| checker = ->() { true } | ||
| detacher = ->(watcher) { event_loop_detach(watcher) } | ||
| timer = Fluent::PluginHelper::Timer::TimerWatcher.new(:closer, @rotate_wait, false, log, checker, detacher) { |
There was a problem hiding this comment.
Why do you extract timer_execute?
The above comment does not describe the reason to extract timer_execute.
I think we should create another PR for extracting timer_execute and use @event_loop_directly.
BTW, how about adding TODO: to the above comment?
There was a problem hiding this comment.
Ah, I forgot to back to timer_execute implementation.
Fix soon.
Signed-off-by: Masahiro Nakagawa <[email protected]>
|
If no problem, I will merge this patch and release rc version for testing. |
cosmo0920
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa [email protected]