fixing regex of pid/procid field for conformance to RFC5424 spec #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Dalley <[email protected]>
|
Don't change capture name because it breaks existing users, e.g. schema mismatch. |
|
Good point. I will resubmit PR to include just the pattern match change and leave the match name 'pid' unchanged. |
|
Replaced by #2051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC5424, the field for PROCID is either a NILVALUE (-) or ASCII field from 1 to 128 characters.
https://tools.ietf.org/html/rfc5424#section-6
Valid RFC5424 formatted log using alphanumeric PROCID value of 'proc1':
<16>1 2013-02-28T12:00:00.003Z 192.168.0.1 fluentd proc1 ID24224 [exampleSDID@20224 iut="3" eventSource="Application" eventID="11211"] Hi, from Fluentd!
The regex in this PR commit will properly match the example above.
Also changed the match field name from pid to procid in the REGEX to line up with RFC5424.