Dump config_argument by dump_config_definition #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous version, fluent-plugin-config-format command does not dump information defined by config_argument. We cannot reconstruct a plugin config definition from dumped config. Signed-off-by: Kenji Okimoto <[email protected]>
|
One test fails. Could you check it? |
chunk_keys is an argument of buffer section. In previous version, chunk_keys type is missing in dumped configuration. In this version, dump arguments first, and dump type of arguments properly. Signed-off-by: Kenji Okimoto <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous version, fluent-plugin-config-format command does not dump
information defined by config_argument. We cannot reconstruct a plugin
config definition from dumped config.