Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in_udp/in_tcp: Fix source_hostname_key #1976

Merged
merged 2 commits into from
May 9, 2018
Merged

in_udp/in_tcp: Fix source_hostname_key #1976

merged 2 commits into from
May 9, 2018

Conversation

repeatedly
Copy link
Member

Fix #1972

@repeatedly repeatedly mentioned this pull request May 7, 2018
Closed
@repeatedly repeatedly requested a review from cosmo0920 May 7, 2018 23:34
@repeatedly repeatedly self-assigned this May 7, 2018
@repeatedly repeatedly added bug Something isn't working v1 labels May 7, 2018
cosmo0920
cosmo0920 approved these changes May 8, 2018
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that hostname will be resolved after applying this PR.
LGTM. 👍

@repeatedly repeatedly merged commit b76c9d2 into master May 9, 2018
@repeatedly repeatedly deleted the fix-source_hostname_key branch May 9, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees

@repeatedly repeatedly

Labels
bug Something isn't working v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @cosmo0920