Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close invalid socket when ssl error happens on reading. fix #1924 #1942

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Close invalid socket when ssl error happens on reading. fix #1924 #1942

merged 1 commit into from
Apr 17, 2018

Conversation

repeatedly
Copy link
Member

We can't recover SSL error so closing socket is better than process crash.
in_forward continue to accept new request.

Signed-off-by: Masahiro Nakagawa [email protected]

@repeatedly repeatedly added bug Something isn't working v1 labels Apr 13, 2018
@repeatedly repeatedly self-assigned this Apr 13, 2018
@repeatedly repeatedly requested a review from mururu April 13, 2018 00:33
@repeatedly repeatedly mentioned this pull request Apr 13, 2018
Closed
mururu
mururu approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@mururu mururu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@repeatedly repeatedly merged commit 410f95b into master Apr 17, 2018
@repeatedly repeatedly deleted the close-invalid-ssl-socket branch April 17, 2018 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mururu mururu mururu approved these changes

Assignees

@repeatedly repeatedly

Labels
bug Something isn't working v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @mururu