Add support for TLS Mutual authentication within forward input #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I will check it soon! |
|
Add unit test is hard for this case. So we need to consider adding other test scenario in the feature. |
|
After CI testing is passed, I will release v1.1.1. |
|
@repeatedly should I also update the docs to reflect this festure? |
|
Yep. https://docs.fluentd.org/v1.0/articles/in_forward#parameters Here is the parameters and https://docs.fluentd.org/v1.0/articles/in_forward#how-to-enable-tls/ssl-encryption is better for how to use this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR add support for Client auth (also knows as Mutual authentication).
This mainly consist of two things:
ca_filefromca_pathconfig. In case config is not set it will default to null, which is also acceptable.client_cert_authconfig is set totruethen configure SSL context to verify peer certificates.This is my first ever ruby code and I'm having trouble understanding how to write test, so I would appreciate any help with that.