Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call proper method for each connection type. fix #1554 #1560

Merged
merged 3 commits into from
May 12, 2017
Merged

Call proper method for each connection type. fix #1554 #1560

merged 3 commits into from
May 12, 2017

Conversation

repeatedly
Copy link
Member

@repeatedly repeatedly commented May 9, 2017 •
edited
Loading

This patch includes additional fixes.

  • Use readpartial for SSLSocket
  • Fix invalid code for event registration

@repeatedly repeatedly requested a review from mururu May 10, 2017 09:17
@repeatedly repeatedly self-assigned this May 10, 2017
@repeatedly repeatedly added bug Something isn't working v0.14 labels May 10, 2017
@repeatedly
Copy link
Member Author

@mururu Could you review this patch?

@repeatedly repeatedly mentioned this pull request May 10, 2017
Closed
mururu
mururu approved these changes May 12, 2017
View reviewed changes
Copy link
Member

@mururu mururu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@repeatedly repeatedly merged commit 3f8630d into master May 12, 2017
@repeatedly repeatedly deleted the fix-1554 branch May 24, 2017 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mururu mururu mururu approved these changes

Assignees

@repeatedly repeatedly

Labels
bug Something isn't working v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @mururu