Allow the Windows Service name Fluentd runs as to be configurable. #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the name, display name and description fluentd is running as when it is a Windows Service to be configured.
repeatedly
reviewed
Apr 20, 2017
lib/fluent/supervisor.rb
Outdated
| @@ -385,6 +385,9 @@ def self.default_options | |||
| standalone_worker: false, | |||
| signame: nil, | |||
| winsvcreg: nil, | |||
| winsvc_name: 'fluentdwinsvc', | |||
There was a problem hiding this comment.
default_options is bad place for these options because
default_options is for Supervisor, not command line.
This is why test failed.
BTW, winsvcreg can be removed from default_options.
There is no use for now.
There was a problem hiding this comment.
Is there another similar place I could add these? I couldn't find one. I can make one in fluentd?
There was a problem hiding this comment.
I just moved these under the fluentd.windows check. PTAL
|
LGTM @nurse Do you see any concern? |
|
@repeatedly Looks good! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the name, display name and description fluentd is running as when it is a Windows Service to be configured.
This also removes an unneeded option 'winsvcreg'