fix to break infinite-loop when shutdown goes on #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change relates #1260 only for v0.14. |
|
@repeatedly could you review this change? |
repeatedly
reviewed
Jan 4, 2017
| # to break infinite loop to exit Fluentd process | ||
| raise | ||
| end | ||
| log.trace "sleepling until buffer can store more data" |
|
LGTM |
tagomoris
force-pushed
the
fix-to-exit-during-buffer-queue-is-blocking
branch
from
13d5e44
to
d3a77e6
Compare
mumoshu
added a commit
to mumoshu/kube-fluentd
that referenced
this pull request
Mar 17, 2017
…n't drop messages anymore This is safe since fluent/fluentd#1396 is included starting v0.14.12 according to https://github.com/fluent/fluentd/blob/master/ChangeLog#L36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Fluentd master:HEAD doesn't run into infinite loop with the configuration file added by this change because thread plugin helper kills all threads (including input plugin thread emitting events).
But this change fixes the problem even with plugins creating threads by plugins themselves.