in_exec: Ensure to sleep for prevending fork bomb #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2016 19:42
For testing, add new mode to exec_script.rb. In this mode, exec_script.rb output a charactor to stderr and then output a invalid json string to stdout. The test case checks that the total length of command's stderr (this means the count of command execution) is appropriate.
|
ping @repeatedly ? |
|
I'm waiting patch update. |
|
Ahh, wait. My comment isn't appear... |
repeatedly
reviewed
Dec 14, 2016
| end | ||
|
|
||
| assert_equal true, d.emits.empty? | ||
| assert_equal true, File.read(@count_file).length.between?(1, 4) |
There was a problem hiding this comment.
For counting command execution, checking log lines seems enough like below:
fluentd/test/plugin/test_in_forward.rb
Line 167 in e307297
|
@repeatedly Thanks for your review and advice! I updated the test code. |
Not needed. Thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 0.12.18,
in_execdose not sleeprun_intervalwhen command or output parsing failed.This causes the fork bomb.
This is prevended by moving
sleep @run_intervaltoensureclause.(Sorry, the added test case may not be good...)