Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug to depend on class name of Fluent::Plugin::MultiOutput #1206

Merged
merged 1 commit into from
Sep 6, 2016
Merged

fix bug to depend on class name of Fluent::Plugin::MultiOutput #1206

merged 1 commit into from
Sep 6, 2016

Commits on Sep 6, 2016

  1. fix bug to depend on class name of Fluent::Plugin::MultiOutput 

    Basically, checking objects with its class name is wrong practice in Ruby. It's should be done with method calls.
When v0.14 MultiOutput plugins are used, Plugin.new_output requires the class at first, so Fluent::Plugin::MultiOutput reference
can succeed. When v0.12 MultiOutput plugins are used, it fails.
Refenrencing classes in core code makes circular dependencies, so we should use method calls to check objects.
    @tagomoris
    tagomoris committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    f3e599d View commit details
    Browse the repository at this point in the history