Support data compression in buffer plugins #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
2 times, most recently
from
3504bec
to
04daf34
Compare
ganmacs
changed the title
ganmacs
changed the title
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
from
04daf34
to
22c86e8
Compare
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
8 times, most recently
from
5208911
to
89c2a2c
Compare
ganmacs
changed the title
| @@ -149,11 +152,31 @@ def open(&block) | |||
| raise NotImplementedError, "Implement this method in child class" | |||
| end | |||
|
|
|||
| def write_to(io) | |||
| def write_to(io, options = {}) | |||
There was a problem hiding this comment.
Use **kwargs instead of tailing option = {}.
|
I added review comments for implementations. |
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
from
66f8c18
to
72dd08c
Compare
|
@tagomoris |
| if @chunk.is_a?(IO) | ||
| # reset io(@chunk) to read | ||
| @chunk.seek(0, IO::SEEK_SET) | ||
| decompress('', io: @chunk) # not to call IO#read |
There was a problem hiding this comment.
Specifying blank string for unused argument looks bad API.
Is there a way to use default value for that parameter? Or any other solution? (At least, nil is better for unused parameter value.)
|
@tagomoris |
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
from
061b2de
to
71970b6
Compare
* to extend Decompressable
if @buffer.compress is true, then use `to_compressed_msgpack_stream`
* use **kwargs * not to call super
* change keyword argument `compress` -> `compressed`
* fix a typo and a bug
and fix resource string
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
3 times, most recently
from
3226342
to
ac376e1
Compare
|
@tagomoris |
ganmacs
force-pushed
the
support-data-compression-in-buffer
branch
from
ac376e1
to
0ed911a
Compare
|
Okay, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
to_compressed_msgpack_streaminEventStreamwrite_toNot for this PR tasks
Close #1169