-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: fix IPV6 handling for accepting connections #9404
Merged
Merged
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomillerOpen
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
September 19, 2024 21:50
This allows for expanded storage to handle IPV6 addresses. Signed-off-by: jomillerOpen <[email protected]>
jomillerOpen
force-pushed
the
master
branch
from
September 23, 2024 15:11
399b82d
to
c1d40b4
Compare
edsiper
changed the title
Fix IPV6 handling for accepting connections
network: fix IPV6 handling for accepting connections
Sep 26, 2024
CI is failing
|
I think I have a fix for the CI. Tested it out locally and it still works with this new change. |
Changed (based on an example) the struct declaration being passed to accept to fix the CI pipeline. Signed-off-by: jomillerOpen <[email protected]>
cosmo0920
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that this patch is working well on my local Windows box, too. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue of IPV6 addresses not being able to be stored properly, causing the connection to never by accepted and an endless loop occurring.
Fixes #9053
Testing
Tested on Windows 11.
Config input/output sections used:
[INPUT]
Name tcp
Chunk_Size 32
Format json
Listen [::1]
Port 5170
tag cs.systemmonitoring
[OUTPUT]
Name stdout
Format json_lines
json_date_format iso8601
json_date_key utc_timestamp
Match cs.systemmonitoring
Client app would open a TCP socket connection, send a json payload, then close the connection. Prior to this fix only IPV4 would work, using IPV6 would cause an endless loop. This fix will allow both IPV4 and IPV6 to work.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.