Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_dummy: switched property types to match the config_map #9213

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

rightblank
Copy link


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@leonardo-albertovich leonardo-albertovich changed the title in_dummy: fix the in_dummy timestamp issue on s390x in_dummy: switched property types to match the config_map Aug 14, 2024
@leonardo-albertovich
Copy link
Collaborator

I changed the subject to properly represent the change made. If you want to make a note about this issue showing on s390 in the description that's ok but this is not an endianness or s390 specific issue and we should clearly communicate the nature of it so someone who is not well informed does not misinterpret it.

@edsiper edsiper merged commit 95d0a98 into fluent:master Aug 15, 2024
4 checks passed
@rightblank rightblank deleted the in_dummy_s390x_issue branch August 16, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants