coverity: report as of 20240813

lib/cmetrics/CMakeLists.txt

@@ -6,7 +6,7 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 # CMetrics Version
 set(CMT_VERSION_MAJOR  0)
 set(CMT_VERSION_MINOR  9)
-set(CMT_VERSION_PATCH  3)
+set(CMT_VERSION_PATCH  4)
 set(CMT_VERSION_STR "${CMT_VERSION_MAJOR}.${CMT_VERSION_MINOR}.${CMT_VERSION_PATCH}")
 
 # Include helpers

lib/cmetrics/include/cmetrics/cmt_decode_statsd.h

@@ -0,0 +1,60 @@
+/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+
+/*  CMetrics
+ *  ========
+ *  Copyright 2021-2022 The CMetrics Authors
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+
+#ifndef CMT_DECODE_STATSD_H
+#define CMT_DECODE_STATSD_H
+
+#include <cmetrics/cmetrics.h>
+
+#define CMT_DECODE_STATSD_TYPE_COUNTER 1
+#define CMT_DECODE_STATSD_TYPE_GAUGE   2
+#define CMT_DECODE_STATSD_TYPE_TIMER   3
+#define CMT_DECODE_STATSD_TYPE_SET     4
+
+#define CMT_DECODE_STATSD_SUCCESS                  0
+#define CMT_DECODE_STATSD_ALLOCATION_ERROR         1
+#define CMT_DECODE_STATSD_UNEXPECTED_ERROR         2
+#define CMT_DECODE_STATSD_INVALID_ARGUMENT_ERROR   3
+#define CMT_DECODE_STATSD_UNEXPECTED_METRIC_TYPE   4
+#define CMT_DECODE_STATSD_DECODE_ERROR             5
+#define CMT_DECODE_STATSD_UNPACK_ERROR             6
+#define CMT_DECODE_STATSD_UNSUPPORTED_METRIC_TYPE  7
+#define CMT_DECODE_STATSD_INVALID_TAG_FORMAT_ERROR 8
+
+#define CMT_DECODE_STATSD_GAUGE_OBSERVER     1 << 0
+
+/*
+ * The "cmt_statsd_message" represents a single line in UDP packet.
+ * It's just a bunch of pointers to ephemeral buffer.
+ */
+struct cmt_statsd_message {
+    char *bucket;
+    int bucket_len;
+    char *value;
+    char *labels;
+    int value_len;
+    int type;
+    double sample_rate;
+};
+
+int cmt_decode_statsd_create(struct cmt **out_cmt, char *in_buf, size_t in_size, int flags);
+void cmt_decode_statsd_destroy(struct cmt *cmt);
+
+#endif

lib/cmetrics/src/CMakeLists.txt

@@ -35,6 +35,7 @@ set(src
   cmt_encode_influx.c
   cmt_encode_msgpack.c
   cmt_decode_msgpack.c
+  cmt_decode_statsd.c
   cmt_mpack_utils.c
   external/remote.pb-c.c
   external/types.pb-c.c

lib/cmetrics/src/cmt_cat.c

@@ -346,20 +346,16 @@ int cmt_cat_untyped(struct cmt *cmt, struct cmt_untyped *untyped,
 int cmt_cat_histogram(struct cmt *cmt, struct cmt_histogram *histogram,
                       struct cmt_map *filtered_map)
 {
-    int i;
-    double val;
     int ret;
     char **labels = NULL;
     struct cmt_map *map;
     struct cmt_opts *opts;
     struct cmt_histogram *hist;
-    uint64_t timestamp;
     struct cmt_histogram_buckets *buckets;
     int64_t buckets_count;
 
     map = histogram->map;
     opts = map->opts;
-    timestamp = cmt_metric_get_timestamp(&map->metric);
 
     ret = cmt_cat_copy_label_keys(map, (char **) &labels);
     if (ret == -1) {
@@ -433,6 +429,8 @@ int cmt_cat_summary(struct cmt *cmt, struct cmt_summary *summary,
                              quantiles,
                              map->label_count, labels);
     if (!sum) {
+        free(labels);
+        free(quantiles);
         return -1;
     }
 

lib/cmetrics/src/cmt_counter.c

@@ -107,8 +107,8 @@ int cmt_counter_inc(struct cmt_counter *counter,
                                 counter->map, labels_count, label_vals,
                                 CMT_TRUE);
     if (!metric) {
-        cmt_log_error(counter->cmt, "unable to retrieve metric: %s for counter %s_%s_%s",
-                      counter->map, counter->opts.ns, counter->opts.subsystem,
+        cmt_log_error(counter->cmt, "unable to retrieve metric for counter %s_%s_%s",
+                      counter->opts.ns, counter->opts.subsystem,
                       counter->opts.name);
         return -1;
     }
@@ -125,8 +125,8 @@ int cmt_counter_add(struct cmt_counter *counter, uint64_t timestamp, double val,
                                 counter->map, labels_count, label_vals,
                                 CMT_TRUE);
     if (!metric) {
-        cmt_log_error(counter->cmt, "unable to retrieve metric: %s for counter %s_%s_%s",
-                      counter->map, counter->opts.ns, counter->opts.subsystem,
+        cmt_log_error(counter->cmt, "unable to retrieve metric for counter %s_%s_%s",
+                      counter->opts.ns, counter->opts.subsystem,
                       counter->opts.name);
         return -1;
     }
@@ -144,8 +144,8 @@ int cmt_counter_set(struct cmt_counter *counter, uint64_t timestamp, double val,
                                 labels_count, label_vals,
                                 CMT_TRUE);
     if (!metric) {
-        cmt_log_error(counter->cmt, "unable to retrieve metric: %s for counter %s_%s_%s",
-                      counter->map, counter->opts.ns, counter->opts.subsystem,
+        cmt_log_error(counter->cmt, "unable to retrieve metric for counter %s_%s_%s",
+                      counter->opts.ns, counter->opts.subsystem,
                       counter->opts.name);
         return -1;
     }
@@ -170,8 +170,8 @@ int cmt_counter_get_val(struct cmt_counter *counter,
                                  counter->map, labels_count, label_vals,
                                  &val);
     if (ret == -1) {
-        cmt_log_error(counter->cmt, "unable to retrieve metric: %s for counter %s_%s_%s",
-                      counter->map, counter->opts.ns, counter->opts.subsystem,
+        cmt_log_error(counter->cmt, "unable to retrieve metric for counter %s_%s_%s",
+                      counter->opts.ns, counter->opts.subsystem,
                       counter->opts.name);
         return -1;
     }

lib/cmetrics/src/cmt_decode_prometheus_remote_write.c

@@ -663,6 +663,7 @@ int cmt_decode_prometheus_remote_write_create(struct cmt **out_cmt, char *in_buf
                                               (uint8_t *) in_buf);
     if (write == NULL) {
         result = CMT_DECODE_PROMETHEUS_REMOTE_WRITE_UNPACK_ERROR;
+        cmt_destroy(cmt);
         return result;
     }