docs: Reference build and install from README #8990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matschaffer-roblox
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
|
Can you sort the DCO @matschaffer-roblox as it's required to merge I'm afraid? |
matschaffer-roblox
force-pushed
the
discussions-6003-doc-cleanup
branch
from
22fe6fd to
6db915b
Compare
Related to fluent#6003 (comment) Signed-off-by: Mat Schaffer <[email protected]>
matschaffer-roblox
force-pushed
the
discussions-6003-doc-cleanup
branch
from
6db915b to
2af08b0
Compare
|
@patrick-stephens looks like I should be set on DCO. Let me know if you need anything else. |
patrick-stephens
approved these changes
Jul 2, 2024
matschaffer-roblox
changed the title
|
Thanks @patrick-stephens ! I'm not entirely sure but seems like the commit message checker might have been flagging the PR subject so I updated it to match |
|
👋 was just checking on open PRs and thought I'd bump this. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the somewhat-incomplete build instructions from the main README with a link to the official documentation.
Related to #6003 (comment)
When I saw the docs in the readme, I tried to apply them directly, but they don't work on macos without some additional homebrew packages.
The official docs (especially https://docs.fluentbit.io/manual/installation/macos#install-build-dependencies) make this much clearer.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.