out_s3: replace MAX_UPLOAD_ERRORS constant with retry_limit #8985
+19
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the constant for the maximum upload errors in the output plugin out_s3 with the user-configurable retry_limit variable and fixes a segfault that occurred when building with debug flags. Signed-off-by: Lucas Heer <[email protected]>
|
ping @PettitWesley |
|
@PettitWesley ping |
|
moving to the next milestone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the constant for the maximum upload errors in the output plugin out_s3 with the user-configurable retry_limit variable and fixes a segfault that occurred when building with debug flags.
Previous attempts for older Fluent Bit versions (#6475, #6063) were not merged to master, presumably because of stability issues.
On our test systems, we can now configure the retry_limit and therefore better handle situations with network instabilities and prolonged network interruptions.
Fixes #8595
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
[OUTPUT]
Name s3
Match *
Bucket fluentbit
Endpoint http://127.0.0.1:9000
Retry_Limit 3
Preserve_Data_Ordering true
Total_File_Size 15M
Use_Put_Object false
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
[N/A]Documentation required for this featureThe docs claim already that the retry_limit is taken into account.
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.