Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_calyptia_fleet: add missing release function on collect #8124

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

nokute78
Copy link
Collaborator

@nokute78 nokute78 commented Nov 3, 2023

This patch is to release resources on collect callback.
data and/or header can not be released on error case.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@nokute78 nokute78 requested a review from pwhelan as a code owner November 3, 2023 01:09
@nokute78 nokute78 temporarily deployed to pr November 3, 2023 01:10 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr November 3, 2023 01:10 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr November 3, 2023 01:10 — with GitHub Actions Inactive
Copy link
Contributor

@pwhelan pwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested changing a configuration and it was correctly reloaded.

@pwhelan pwhelan merged commit 818de85 into fluent:master Nov 3, 2023
42 checks passed
@nokute78 nokute78 deleted the collect_in_calyptia_fleet branch November 3, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants