Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_docker: Add unit test and make configurable paths #8100

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Oct 27, 2023

Follows up #8087


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found
==512080== 
==512080== HEAP SUMMARY:
==512080==     in use at exit: 0 bytes in 0 blocks
==512080==   total heap usage: 2,888 allocs, 2,888 frees, 798,713 bytes allocated
==512080== 
==512080== All heap blocks were freed -- no leaks are possible
==512080== 
==512080== For lists of detected and suppressed errors, rerun with: -s
==512080== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

==512087== 
==512087== HEAP SUMMARY:
==512087==     in use at exit: 0 bytes in 0 blocks
==512087==   total heap usage: 2,894 allocs, 2,894 frees, 806,053 bytes allocated
==512087== 
==512087== All heap blocks were freed -- no leaks are possible
==512087== 
==512087== For lists of detected and suppressed errors, rerun with: -s
==512087== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-runtime-test-in_docker branch from e60f907 to f8780b3 Compare October 27, 2023 16:10
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 16:11 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 16:11 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 16:11 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 16:40 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 marked this pull request as ready for review October 27, 2023 17:17
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 22:19 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 22:19 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 22:19 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr October 27, 2023 22:50 — with GitHub Actions Inactive
@edsiper edsiper merged commit a07f45b into master Nov 6, 2023
42 of 43 checks passed
@edsiper edsiper deleted the cosmo0920-add-runtime-test-in_docker branch November 6, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants