Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flb_utils: add code for getting the machineID on macOS. #8096

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Oct 26, 2023

Summary

Add code to get the machineID (serial number) on macOS machines.

This value is used after hashing it to identify agents in a fleet that does not have a machineID already assigned manually with the MachineID configuration property.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan temporarily deployed to pr October 26, 2023 19:09 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 19:09 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 19:09 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 19:37 — with GitHub Actions Inactive
@edsiper edsiper merged commit 14bba1f into master Nov 7, 2023
43 checks passed
@edsiper edsiper deleted the pwhelan-utils-macos-machineid branch November 7, 2023 03:28
@edsiper
Copy link
Member

edsiper commented Nov 7, 2023

@pwhelan merged, thanks. Please note that prefix must not have the flb_ prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants