Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key [backport to 2.1] #8094

Open
wants to merge 1 commit into
base: 2.1
Choose a base branch
from

Conversation

igorpeshansky
Copy link
Contributor

Backport of #8093 to the 2.1 branch.

This fixes the use case of specifying the service_account_email and service_account_secret options explicitly.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
    [OUTPUT]
      Name        stackdriver
      Match       …
      service_account_email …
      service_account_secret …
    
  • [N/A] Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.
    This is the backport.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:22 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:22 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:22 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky force-pushed the 2.1-fix-credentials-options branch from 6f6ad5b to bf2d023 Compare October 26, 2023 16:24
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:25 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:25 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:25 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky changed the title Backport of #8093: Only set ctx->client_email and ctx->private_key when previously unset. Backport of #8093: out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key. Oct 26, 2023
@igorpeshansky igorpeshansky changed the title Backport of #8093: out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key. out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key. Oct 26, 2023
@igorpeshansky igorpeshansky temporarily deployed to pr October 26, 2023 16:56 — with GitHub Actions Inactive
@igorpeshansky igorpeshansky changed the title out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key. out_stackdriver: Don't overwrite ctx->client_email and ctx->private_key [backport to 2.1] Oct 26, 2023
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants