Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_calyptia: correctly set fleet_id for out_calyptia when fleet_name is set. #8089

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Oct 26, 2023

Summary

Setting the fleet_id for the output plugin was done in two places as well as hidden behind an else condition that would never execute. This change should more reliably set fleet_id for the calyptia output plugin.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan requested a review from niedbalski October 26, 2023 12:57
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 12:57 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 12:57 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 12:57 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 26, 2023 13:32 — with GitHub Actions Inactive
@edsiper edsiper merged commit 8d96a27 into master Oct 29, 2023
43 checks passed
@edsiper edsiper deleted the pwhelan-calyptia-report-fleet-id-label-with-name branch October 29, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants