http_server: v2: reload: windows: Enable hot reloading #7984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of calyptia-fleet works on Windows, we can also offer for enabling hot-reloading on Windows. :)
However, Windows does not have SIGHUP signal. So, I enabled only for HTTP API for reloading.
Note that GenerateConsoleCtrlEvent returns nonzero when succeeded.
ref: https://learn.microsoft.com/en-us/windows/console/generateconsolectrlevent
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
PS> bin/fluent-bit -i random -o stdout -H -P 2020 -Y -v
On Another Terminal
Fluent Bit Terminal
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1209
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.