-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_node_exporter_metrics: Initial support for macOS metrics #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
September 20, 2023 03:28
cosmo0920
force-pushed
the
cosmo0920-node_exporter_metrics-on-macOS
branch
from
September 20, 2023 03:34
814ebc7
to
613dede
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-node_exporter_metrics-on-macOS
branch
from
September 20, 2023 03:38
613dede
to
4cde143
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
changed the title
in_node_exporter_metrics: Initial suppport for macOS metrics
in_node_exporter_metrics: Initial support for macOS metrics
Sep 20, 2023
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the initial support for macOS, I implemented cpu,loadavg,meminfo,diskstats,uname, and netdev metrics.
Note that diskstats metrics depend on IOKit and Foundation frameworks which could introduces binary incompatibilities for macOS 12.0 (Monterey) or older.
In macOS, meminfo and vmstat metrics should be overlapped their information. So, I decided to provide meminfo metrics and not to provide vmstat metrics.
No referred issues for this PR. This is started for a researching task to support macOS metrics.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
$ bin/fluent-bit -i node_exporter_metrics -o stdout
In macOS, valgrind is not runnable but leaks command can be used for leak detection:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1197
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.