Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_kubernetes_events: allow setting kube_token_file as empty for use with kubectl proxy. #7567

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Jun 14, 2023

Summary

When using kubectl proxy it is possible to not use a token and skip authentication. This patch allows setting kube_token_file as an empty string to avoid having to load the token file.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan temporarily deployed to pr June 14, 2023 19:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr June 14, 2023 19:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr June 14, 2023 19:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr June 14, 2023 20:08 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr June 14, 2023 20:09 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr June 14, 2023 20:09 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr June 14, 2023 20:33 — with GitHub Actions Inactive
@edsiper edsiper merged commit bc28e78 into master Jul 3, 2023
@edsiper edsiper deleted the pwhelan-k8s_events_proxy_no_token branch July 3, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants