Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_node_exporter_metrics: textfile: Plug unhandled NULL case #7529

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

cosmo0920
Copy link
Contributor


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
[SERVICE]
    flush           1
    log_level       debug

[INPUT]
    name            node_exporter_metrics
    tag             fluentbit.metrics.${HOSTNAME}
    scrape_interval 2
    collector.textfile.path /path/to/prom_payloads/prom_metrics/*/*.prom

    metrics textfile

[OUTPUT]
    name stdout
    Match *
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found
==511818== 
==511818== HEAP SUMMARY:
==511818==     in use at exit: 95,170 bytes in 702 blocks
==511818==   total heap usage: 16,152 allocs, 15,450 frees, 50,327,111 bytes allocated
==511818== 
==511818== LEAK SUMMARY:
==511818==    definitely lost: 0 bytes in 0 blocks
==511818==    indirectly lost: 0 bytes in 0 blocks
==511818==      possibly lost: 0 bytes in 0 blocks
==511818==    still reachable: 95,170 bytes in 702 blocks
==511818==         suppressed: 0 bytes in 0 blocks
==511818== Reachable blocks (those to which a pointer was found) are not shown.
==511818== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==511818== 
==511818== For lists of detected and suppressed errors, rerun with: -s
==511818== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 temporarily deployed to pr June 8, 2023 07:47 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr June 8, 2023 07:47 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr June 8, 2023 07:47 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr June 8, 2023 08:09 — with GitHub Actions Inactive
@edsiper edsiper merged commit a83a5c0 into master Jun 13, 2023
@edsiper edsiper deleted the cosmo0920-handle-NULL-case-from-flb_file_read branch June 13, 2023 14:45
@edsiper edsiper added this to the Fluent Bit v2.1.5 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants