-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_opensearch: Add gzip compression #7381
out_opensearch: Add gzip compression #7381
Conversation
Signed-off-by: wndhydrnt <[email protected]>
984d90e
to
825ebea
Compare
Example configuration file
Debug logCommand to start OpenSearch:
Valgrind outputValgrind repeatedly prints the message |
Would you mind if you added the test case for your change? |
Hey @cosmo0920, thank you for your suggestion. When writing the change, I could not come up with a good way to test it. I have to admit that this is the first time for me contributing to a codebase written in C, so it might just be a matter of lack of experience. It would be helpful to me if you can provide some hints on how to approach the implementation of a test. |
To be fair there is no easy way to do it (in our codebase) that I know of and this is a fairly rutinary change (there's been a few of the same within the past few weeks) so as long as it's approved by a maintainer I think we could skip the unit test and make a note to ourselves to improve that aspect of the testing system. |
Signed-off-by: wndhydrnt <[email protected]>
…algorithm extensible Signed-off-by: wndhydrnt <[email protected]>
Thanks for fixing those issues @wndhydrnt, this is ready to be merged. |
This change adds support for compressing the payload sent to an OpenSearch server using gzip.
Compression is off by default, similar to other outputs that support compression.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1104
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.