-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_kafka: use log encoder #7359
Merged
leonardo-albertovich
merged 2 commits into
fluent:master
from
Syn3rman:kafka-log-encoder
May 11, 2023
Merged
in_kafka: use log encoder #7359
leonardo-albertovich
merged 2 commits into
fluent:master
from
Syn3rman:kafka-log-encoder
May 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of FLB_LOG_EVENT_NULL_VALUE_TYPE, we were not reaching the desired condition due to an earlier check on value_buffer. We re-order the conditionals to make sure nil is packed correctly. Signed-off-by: Aditya Prajapati <[email protected]>
Syn3rman
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
May 11, 2023 08:47
leonardo-albertovich
requested changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once these changes are addressed this will be ready to be merged.
Syn3rman
force-pushed
the
kafka-log-encoder
branch
from
May 11, 2023 11:07
1e62c1b
to
258645b
Compare
Signed-off-by: Aditya Prajapati <[email protected]>
Syn3rman
force-pushed
the
kafka-log-encoder
branch
from
May 11, 2023 15:55
258645b
to
e1900b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use log_encoder instead of mpack in in_kafka
#7301
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.