mp: updated the format check to accept the new format released with 2.1 #7287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
patrick-stephens
temporarily deployed
to
unstable
GitHub Actions
Inactive
patrick-stephens
temporarily deployed
to
pr-package-test
GitHub Actions
Inactive
patrick-stephens
temporarily deployed
to
pr-package-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in
flb_mp_validate_log_chunkwhich I didn't update to use the log event abstraction layer before the release (because I missed it).Originally I intended to update the code to use the log event decoder but there is something about possible the trailing bytes I'm not sure about so I patched it to comply with the new format in order to fix the issue while minimizing the possibility of introducing new bugs.
We should modernize it in the near future but I don't think this is the right time.