Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: handle systemd service detection #7193

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Apr 14, 2023

Resolves #7189 to ensure systemd services are included in appropriate packages.
Changes in #5818 seem to be triggeringpkg-config issues in the container builds for some targets so adding the old default as well.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@patrick-stephens patrick-stephens added packaging ok-package-test Run PR packaging tests and removed docs-required labels Apr 14, 2023
@patrick-stephens patrick-stephens temporarily deployed to unstable April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to unstable April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr-package-test April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr-package-test April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr-package-test April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr-package-test April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 13:31 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr-package-test April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens patrick-stephens temporarily deployed to pr-package-test April 14, 2023 15:00 — with GitHub Actions Inactive
@patrick-stephens
Copy link
Contributor Author

The macos test failures are unrelated, just a tweak to CI separately to enable them to fail.

@ptsneves
Copy link
Contributor

I am fine with this PR. It tries to fallback. I checked that debian indeed does not ship systemd's original pkgconfig. I am investigating why but this is a good patch.

@patrick-stephens
Copy link
Contributor Author

patrick-stephens commented Apr 14, 2023

I am fine with this PR. It tries to fallback. I checked that debian indeed does not ship systemd's original pkgconfig. I am investigating why but this is a good patch.

My suspicion is we may need to use something like the --with-systemdsystemunitdir configure argument, I'm guessing something in the container definition is missing to provide the relevant information on Debian. However the priority for now was to get it working for the upcoming 2.1 release so just went simple.

@patrick-stephens patrick-stephens merged commit be1f6e0 into master Apr 14, 2023
@patrick-stephens patrick-stephens deleted the 7189_default_systemd_location branch April 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-package-test Run PR packaging tests packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No systemd service in Debian packages in master
2 participants