-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_gelf: New input plugin for ingest GELF messages - rebased #4156 #7082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
stevesowerbutts
requested review from
fujimotos,
niedbalski,
patrick-stephens,
edsiper,
leonardo-albertovich and
koleini
as code owners
March 28, 2023 21:21
Signed-off-by: Manuel Luis Sanmartín Rozada <[email protected]>
stevesowerbutts
force-pushed
the
ml-in_gelf-rebase
branch
from
March 28, 2023 21:24
e570e04
to
78fbd4f
Compare
@@ -166,6 +166,7 @@ option(FLB_IN_EVENT_TEST "Enable Events test plugin" | |||
option(FLB_IN_EVENT_TYPE "Enable event type plugin" Yes) | |||
option(FLB_IN_FLUENTBIT_METRICS "Enable Fluent Bit metrics plugin" Yes) | |||
option(FLB_IN_FORWARD "Enable Forward input plugin" Yes) | |||
option(FLB_IN_GELF "Enable GELF input plugin" Yes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing: does this build on Mac and Windows targets? If not it needs to be disabled for those in the custom cmake config they have.
patrick-stephens
temporarily deployed
to
unstable
March 29, 2023 08:43 — with
GitHub Actions
Inactive
It looks like the code needs an update/rebase as it doesn't build. |
patrick-stephens
temporarily deployed
to
pr-package-test
March 29, 2023 08:43 — with
GitHub Actions
Inactive
patrick-stephens
had a problem deploying
to
pr-package-test
March 29, 2023 08:44 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New input plugin for ingest GELF messages from TCP and UDP.
In UDP support for gzip and zlib compressed messages, and chunked messages.
This is created from @manuelluis in_gelf and rebased against the current master.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.