-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder_utf8: do not read escaped newline (#615) #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the UTF-8 decoder, it tries to read escaped char for general purpose. Escaping a new-line is valid in JSON encoding, if it lines a UTF-8 decoder and then a JSON decoder, the JSON decoder will fail, as the escaped new-line is treated as a real newline in the first UTF-8 decoder. This fixes the issue in fluent#615 Signed-off-by: Richard Meng <[email protected]>
After the change, my config for K8s is like below,
It will handle the case blow,
|
@edsiper Can you please merge this? |
thanks. Merged into 0.13 branch (I will port the change to 0.14) |
edsiper
pushed a commit
that referenced
this pull request
Aug 16, 2018
Signed-off-by: Eduardo Silva <[email protected]>
rawahars
pushed a commit
to rawahars/fluent-bit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Patrick Stephens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UTF-8 decoder, it tries to read escaped char for general
purpose. Escaping a new-line is valid in JSON encoding, if it
lines a UTF-8 decoder and then a JSON decoder, the JSON decoder
will fail, as the escaped new-line is treated as a real newline
in the first UTF-8 decoder.
This fixes the issue in #615
Signed-off-by: Richard Meng [email protected]