Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out_http: gzip encoding support #687

Closed
wants to merge 4 commits into from
Closed

out_http: gzip encoding support #687

wants to merge 4 commits into from

Conversation

kushwiz
Copy link
Contributor

@kushwiz kushwiz commented Jul 19, 2018

  • Use existing miniz lib from out_td plugin
  • Move miniz to lib and write util for the same
  • Add new flag gzip_encode for out_http plugin

Signed-off-by: Kushal Bhandari [email protected]

@kushwiz
Copy link
Contributor Author

kushwiz commented Jul 19, 2018

Fixes #688

@kushwiz kushwiz force-pushed the kushwiz/gzip_out_http branch from e78fd87 to 281a51c Compare July 19, 2018 23:41
@edsiper
Copy link
Member

edsiper commented Aug 15, 2018

@kushwiz

would you please split the changes in different commits ?, e.g:

  • lib/gzip: add gzip compression library
  • core: new zip interface to expose compression feature
  • out_http: add support for gzip compression
  • out_td: use new zip API
  • ...

@edsiper edsiper added the waiting-for-user Waiting for more information, tests or requested changes label Aug 15, 2018
@kushwiz kushwiz force-pushed the kushwiz/gzip_out_http branch from 281a51c to 8cd92e5 Compare August 31, 2018 03:47
@kushwiz kushwiz force-pushed the kushwiz/gzip_out_http branch from 8cd92e5 to 264a402 Compare August 31, 2018 03:54
@kushwiz
Copy link
Contributor Author

kushwiz commented Aug 31, 2018

Oh a lot has changed in out_http. I will need some more time to fix this.

@edsiper
Copy link
Member

edsiper commented Nov 23, 2018

Closing this one as a timeout, the feature is still desired, it can be re-opened if the plugin is updated again.

@edsiper edsiper added the timeout no response or no updates as requested label Nov 23, 2018
@edsiper edsiper closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
timeout no response or no updates as requested waiting-for-user Waiting for more information, tests or requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kushwiz @edsiper