-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream: remove keepalive close event on cleanup #6845
Merged
leonardo-albertovich
merged 1 commit into
fluent:master
from
PettitWesley:sync-io-keepalive-fix-master
Apr 12, 2023
Merged
upstream: remove keepalive close event on cleanup #6845
leonardo-albertovich
merged 1 commit into
fluent:master
from
PettitWesley:sync-io-keepalive-fix-master
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PettitWesley
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
February 13, 2023 20:13
@edsiper @leonardo-albertovich Can we get this bug fix reviewed and merged? IIRC we had a meeting in February and Eduardo said that Leonardo would review it. |
PettitWesley
force-pushed
the
sync-io-keepalive-fix-master
branch
from
April 11, 2023 22:18
45482ed
to
f63030a
Compare
PettitWesley
force-pushed
the
sync-io-keepalive-fix-master
branch
from
April 11, 2023 22:22
f63030a
to
8c176a3
Compare
Resolves this issue: fluent#6821 Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
force-pushed
the
sync-io-keepalive-fix-master
branch
from
April 11, 2023 23:12
8c176a3
to
48051a3
Compare
@leonardo-albertovich tested it by adding a log statement as we discussed: an async IO plugin: cloudwatch_logs:
and a (currently in master) sync IO plugin: s3:
|
leonardo-albertovich
approved these changes
Apr 11, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6821
Currently the keepalive dropped connection event is only removed in the async case. However, sync connections can also have keepalive. This PR ensures the event is always removed if it was added.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.