-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: add 1.8 branch container build #6189
Conversation
Signed-off-by: Patrick Stephens <[email protected]>
why master and not 1.8 branch ? (just curious) |
There's no real technical reason, just a philosophical one. Primarily for simplicity: we have a single source of truth rather than having to merge/duplicate every change across them plus figuring out which workflows should fire (e.g. for PRs) is more straightforward. Initially as well I did not want to touch the workflows for the old branch (1.8) when I started so it made a nice separation. It also means you do not have to remember to run the workflow on the right branch and we can instigate some protection via environments (e.g. you can only release from a master workflow). |
There are some other issues as well with using the non-default branch: https://devopsjournal.io/blog/2022/08/12/workflows-not-starting @edsiper @lecaros : in this case we want a new workflow to be available as a manual trigger so it must be on the default branch at least to enable the workflow (even if you then target another branch) - we could then also merge it to 1.8 but that seems pointless when we can do the build regardless. |
Great explanation. Thanks @patrick-stephens! |
can we merge this? |
thanks! |
Signed-off-by: Patrick Stephens <[email protected]> Signed-off-by: Patrick Stephens <[email protected]> Signed-off-by: Manal Geries <[email protected]>
Signed-off-by: Patrick Stephens <[email protected]> Signed-off-by: Patrick Stephens <[email protected]> Signed-off-by: root <[email protected]>
Signed-off-by: Patrick Stephens [email protected]
After removal of 1.8 build support, this re-introduces a separate workflow to provide a container build for a 1.8 based branch.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.