in_opentelemetry: use ctraces to decode binary payload #6180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn3rman
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
edsiper
requested changes
Oct 11, 2022
| if (result == 0) { | ||
| ctx->ins->event_type = FLB_INPUT_TRACES; | ||
| result = flb_input_trace_append(ctx->ins, NULL, 0, decoded_context); | ||
| // ctr_decode_opentelemetry_destroy(decoded_context); |
There was a problem hiding this comment.
isn't this leading to a memory leak ? decode_context is not been destroyed
|
make sure to include a valgrind output with --leak-check=full |
Signed-off-by: Aditya Prajapati <[email protected]>
Syn3rman
force-pushed
the
aditya-traces-in-otel
branch
from
cdf201c to
b9c9cef
Compare
|
@edsiper fixed and attached valgrind output |
mgeriesa
pushed a commit
to mgeriesa/fluent-bit
that referenced
this pull request
Oct 25, 2022
Signed-off-by: Aditya Prajapati <[email protected]> Signed-off-by: Manal Geries <[email protected]>
sumitd2
pushed a commit
to sumitd2/fluent-bit
that referenced
this pull request
Feb 8, 2023
Signed-off-by: Aditya Prajapati <[email protected]> Signed-off-by: root <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw_tracesthat decides whether to process or forward tracesSigned-off-by: Aditya Prajapati [email protected]
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
https://pastebin.com/cyfC0DNS
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
fluent/fluent-bit-docs#872
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.