Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: switch to SHA rather than ref #5000

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Mar 7, 2022

Signed-off-by: Patrick Stephens [email protected]

Fixes #4999 by using the SHA as the tag name.
This allows us to identify the specific image used in each integration test run rather than a floating latest one with its inherent race conditions between build & provision+test.

Unfortunately as this is pull_request_target it will run with the base workflow.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@patrick-stephens patrick-stephens temporarily deployed to integration March 7, 2022 11:15 Inactive
@patrick-stephens patrick-stephens temporarily deployed to integration March 7, 2022 11:21 Inactive
@niedbalski niedbalski merged commit fc51f21 into master Mar 8, 2022
@patrick-stephens patrick-stephens deleted the 4999_fix_image_tag_name_for_integration_tests branch March 18, 2022 19:32
mgeriesa pushed a commit to mgeriesa/fluent-bit that referenced this pull request Oct 25, 2022
Signed-off-by: Patrick Stephens <[email protected]>
Signed-off-by: Manal Geries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test build fails if branch has special characters in its name
2 participants