Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_cloudwatch_logs: Only create log group if it does not already exist #4827

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

PettitWesley
Copy link
Contributor

See: #4826

Signed-off-by: Wesley Pettit [email protected]


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Copy link
Contributor

@matthewfala matthewfala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@matthewfala matthewfala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failing on 1.8 for this diff?

@PettitWesley PettitWesley force-pushed the create-log-group-master branch from 5e680b5 to 67c5436 Compare February 17, 2022 02:24
@PettitWesley
Copy link
Contributor Author

@edsiper I actually don't have power to merge my own PR on master even if it passes all checks
Screen Shot 2022-02-28 at 8 43 54 PM

CC @agup006 @nokute78

@nokute78
Copy link
Collaborator

nokute78 commented Mar 4, 2022

@PettitWesley @edsiper I also can't merge it.

In this case, the PR was updated after approving.
Currently no one approves and it may prevent merging.

@lecaros lecaros added this to the Fluent Bit v1.9.2 milestone Apr 4, 2022
@edsiper
Copy link
Member

edsiper commented Apr 5, 2022

there is a code conflict:

plugins/out_cloudwatch_logs/cloudwatch_api.c

@PettitWesley PettitWesley force-pushed the create-log-group-master branch from 67c5436 to 7be9a72 Compare April 5, 2022 23:19
@PettitWesley PettitWesley reopened this Apr 5, 2022
…st to prevent throttling

Signed-off-by: Wesley Pettit <[email protected]>
@PettitWesley PettitWesley force-pushed the create-log-group-master branch from 7be9a72 to 39c9f76 Compare April 5, 2022 23:25
@edsiper edsiper merged commit ac3e0ea into fluent:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants