tls: Load system certificates on Windows #4751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesse Schwartzentruber [email protected]
This change ports the code from the mbed implementation to iterate over the Windows CA store and load each into the OpenSSL CA store.
Fixes #4735
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
In the below case I ran in another terminal:
echo hello world > live.log
I confirmed this line is reported to Google Cloud Logs properly.
With
windows_load_system_certificates
commented out, same machine and config.In this case I again ran
echo hello world 2 >> live.log
and confirmed this line was not reported to Google Cloud Logs.If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
1.8: #4752
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.