filter_multiline: implemented buffered mode using in_emitter #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PettitWesley
requested review from
edsiper,
fujimotos and
koleini
as code owners
3 tasks
|
Hello I suspect that the issue is related to that PR. |
|
looks like is failing due to old code ? https://github.com/fluent/fluent-bit/runs/4910999830?check_suite_focus=true#step:5:1464 I suggest to rebase this on top of master so we can trigger the CI again |
PettitWesley
force-pushed
the
multiline-pr-1-master
branch
from
11243be to
8556083
Compare
|
@edsiper I rebased and then re-tested. However, some checks are still failing but it looks like its failing tests that weren't changed by my code... |
PettitWesley
force-pushed
the
multiline-pr-1-master
branch
from
8556083 to
fa0bdf9
Compare
6 tasks
|
@PettitWesley not sure what can be, can you re-rebase again ? |
PettitWesley
force-pushed
the
multiline-pr-1-master
branch
2 times, most recently
from
3e95d6a to
e78e82f
Compare
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
force-pushed
the
multiline-pr-1-master
branch
from
e78e82f to
73aa0c7
Compare
Signed-off-by: Wesley Pettit <[email protected]>
|
@lecaros Can we get this in 1.9.2? We already released it in 1.8, and I just pushed a commit which should fix the CI failure. |
Signed-off-by: Wesley Pettit <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master version of: #4383
Part of: #4309
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
filter_multiline: add docs for new buffered mode fluent-bit-docs#675
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.