tls: Issue #4098 Fix error handling for OpenSSL apis #4584
Conversation
|
I don't understand why the Merge Bot failed. Did I create this PR incorrectly? |
|
no idea :/ @patrick-stephens can you give us a hand ? |
|
I saw this yesterday on another PR targeting the 1.8 branch, I think the credentials need a refresh which I think is @niedbalski domain currently. |
|
The gist after a quick discussion with @niedbalski is ignore the failure - we'll remove the mergebot shortly. |
|
So this is all good to go from a CI perspective, I'll let someone else review the actual content. Ignore the mergebot failure. |
|
I just realized I added some more changes from master by mistake when resolving the merge conflict in my cherry-pick. I will submit a new commit with only my changes. |
krispraws
force-pushed
the
flb_1_8_issue_4098_fix
branch
from
a179eac to
f2bf416
Compare
Signed-off-by: Ramya Krishnamoorthy <[email protected]>
krispraws
force-pushed
the
flb_1_8_issue_4098_fix
branch
from
f2bf416 to
a78fce2
Compare
|
I have updated the commit and removed the unwanted changes from master. |
nokute78
added
the
backport to v1.8.x
|
@edsiper , @fujimotos , @koleini - Please review this when you get a chance. |
|
thank you! |
Signed-off-by: Ramya Krishnamoorthy <[email protected]>
Signed-off-by: Ramya Krishnamoorthy <[email protected]>
Signed-off-by: Ramya Krishnamoorthy [email protected]
This PR backports the fix for issue #4098 to 1.8
Details of the issue and the fix are in PR to merge the fix into
masterFluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.