Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use more portable variable initialization for 1.8 branch #4354

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

nokute78
Copy link
Collaborator

This PR is for v1.8 branch.
Original patch is #4196 and I cherry-picked.

Fixes #4255


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [N/A] Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@nokute78 nokute78 changed the title tests: use more portable variable initialization tests: use more portable variable initialization for 1.8 branch Nov 19, 2021
@nokute78 nokute78 added the backport to v1.8.x Used to tag items that must be backported to such version. label Nov 20, 2021
@nokute78 nokute78 merged commit 954a4a7 into fluent:1.8 Nov 22, 2021
@nokute78
Copy link
Collaborator Author

Merge this PR since I already reviewed #4196 and this is cherry-picked pull request.

@nokute78 nokute78 deleted the cherry-pick-4196_for_1.8 branch November 22, 2021 22:15
@edsiper
Copy link
Member

edsiper commented Nov 29, 2021

Please make sure the commits has the proper "prefix". For PRs where the title is OK but the commit different, by choosing the Squash option instead of rebase allows to override the commit message.

@nokute78
Copy link
Collaborator Author

@edsiper Sorry I forgot to point the prefix at #4196 . I will take care it.

For PRs where the title is OK but the commit different

Hmm, I think it should be checked by CI, but it checks PR title only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v1.8.x Used to tag items that must be backported to such version. docs-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants